-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sdk to 32 and update dependencies for MD3 #873
Conversation
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @Bnyro on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot |
I noticed there's a crash:
LogA resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. java.lang.Throwable: Explicit termination method 'end' not called at dalvik.system.CloseGuard.open(CloseGuard.java:180) at java.util.zip.Inflater.(Inflater.java:104) at java.util.zip.GZIPInputStream.(GZIPInputStream.java:76) at java.util.zip.GZIPInputStream.(GZIPInputStream.java:89) at de.schildbach.pte.AbstractHafasLegacyProvider.lambda$queryTripsBinary$2$de-schildbach-pte-AbstractHafasLegacyProvider(AbstractHafasLegacyProvider.java:1430) at de.schildbach.pte.AbstractHafasLegacyProvider$$ExternalSyntheticLambda0.onSuccessful(D8$$SyntheticClass) at de.schildbach.pte.util.HttpClient.getInputStream(HttpClient.java:291) at de.schildbach.pte.util.HttpClient.getInputStream(HttpClient.java:228) at de.schildbach.pte.util.HttpClient.getInputStream(HttpClient.java:224) at de.schildbach.pte.AbstractHafasLegacyProvider.queryTripsBinary(AbstractHafasLegacyProvider.java:1428) at de.schildbach.pte.AbstractHafasLegacyProvider.queryTripsBinary(AbstractHafasLegacyProvider.java:1388) at de.schildbach.pte.AbstractHafasLegacyProvider.queryTrips(AbstractHafasLegacyProvider.java:688) at de.grobox.transportr.trips.search.TripsRepository.queryTrips(TripsRepository.kt:110) at de.grobox.transportr.trips.search.TripsRepository.access$queryTrips(TripsRepository.kt:52) at de.grobox.transportr.trips.search.TripsRepository$search$1.invoke(TripsRepository.kt:104) at de.grobox.transportr.trips.search.TripsRepository$search$1.invoke(TripsRepository.kt:104) at kotlin.concurrent.ThreadsKt$thread$thread$1.run(Thread.kt:30)Unfortunately I have really no idea how to fix that, it's already running in a It looks like there's a memory leak in |
This doesn't look like a crash, just a resource leak. Sure that's the right stack trace? |
I haven't checked what would cause this but I can reproduce it. The app is just ANR with log
|
I've downgraded some library versions now (since they depend on certain versions of each other), seems like we didn't actually require bumping all the versions so up for using Material Design 3. Anyways it's a bit odd that the |
Yeah, that's not great. From what I heard, we'll move eventually away from MapBox. 🤞 |
Can you tell the bot again that you agree with the CLA? |
Hey cla bot, I agree with the CLA :) |
Build failed. |
Yes, I agree to the CLA ... |
Looks like there is some problem with the dependency pinning again:
Maybe we'd need to update https://github.com/grote/Transportr/blob/master/update-dependency-pinning.sh to exclude that dependency from |
Sounds reasonable. Would you mind suggesting the changes to |
Edit: never mind - pushed to your branch. looks like the Java version is good now but we got a new error. from what ialokim suggested, can we try to update the update-dependency-pinning.sh? I believe we have to change from The line should be
Thanks again! |
I just pushed to your branch. |
lol, failed with another error. I will look into this over the weekend then. Thanks for your patience. |
Oh no, not yet an other one, the CI doesn't play in our team this time apparently :-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, thanks for your contribution.
The change looks good to me. I'll leave this open for a few more days in case somebody else wants to review it.
Sorry for the delay - been slammed at work. I will re-test and merge over this coming weekend unless anyone wants to review. |
closes #869