Crash when Trip with GPS coordinates is made a Favourite Trip

[bkqtnte10]

Tapping the Star-Icon on a Trip with GPS coordinates crashes the app

To Reproduce

1. select a point on the map (coordinates) and use it as "from here"
2. make sure the coordinates don't get mapped to an address (for example by setting the phone to airplane mode)
3. Choose any other location as destination
4. exit airplane mode
5. search for connections (tap "try again")
6. hit the star-icon
7. See error

Expected behavior
Either

• an error message, that coordinates cannot be set as favorite

or

• successfully accepting the new favorite without an error

Screenshots

Versions:

• Transportr Version: 2.0.6
• Device: Xiaomi Mi 6
• Android Version: LineageOS 8.1

[ialokim]

Either

• an error message, that coordinates cannot be set as favorite

or

• successfully accepting the new favorite without an error

@grote What would be the preferred behavior here?

[grote]

I think the expected behavior is to not offer the option to make a trip a favorite that isn't supported. However, there's nothing wrong supporting it. The idea was to use the geocoder to turn the coords into real addresses, but not all providers support the way we currently use: #517
In this case, the geocoding either failed or wasn't fast enough I guess.

[Altonss]

In which networks is it possible to use such GPS coordinates as input? Didn't manage to make a trip...