If there is more than one street with the same name, transportr may pick the wrong one

[2b-as]

(Not sure if this is a Transportr or public-transport-enabler issue, please let me know)

Describe the bug
If there is more than one street with the same name in your city, an Transportr tries to infer the street you are in from your GPS coordinates, it might pick the wrong one, resulting in completely wrong results.

To Reproduce
Steps to reproduce the behavior:

1. Be in a street whose name exists more than once in your city, e.g. "Scharnweberstr." in Berlin
2. Launch "Transportr"
3. Type any destination in the search box at the top
4. Select a station from the resulting drop-down box
5. Tap the red arrow in the lower right corner
6. No matter which street you are actually in, the same one of the streets with the same name gets always picked as start point (in my example: Scharnweberstr. in Reinickendorf gets always picked, even if I am in Scharnweberstr. in Friedrichshain)
7. Displayed results are completely wrong, of course, if you are in another street by the same name

Expected behavior
When the coordinates get resolved to a street name, the zip code should be taken into consideration

Versions (please complete the following information):

• Transportr Version: 2.0.2
• Device: Samsung S8
• Android Version: 8.0

[grote]

Interesting bug. It could be that the data source (network provider) prefers to use the street name even if precise GPS coordinates are available.

Could you test if the same happens with VBB, DB and BVG?

[2b-as]

It only happens with BVG! VBB and DB are not affected. So how do I report the bug to BVG?! Interestingly, if I select the same position from the map on their webpage, everything works as it should.

[grote]

Transportr creates a "fake" location based on GPS data like this:

Transportr/app/src/main/java/de/grobox/transportr/locations/ReverseGeocoder.kt

Line 129 in 64257bf

val l = Location(ADDRESS, null, latInt, lonInt, place, name)

The BvgProvider uses the new AbstractHafasMobileProvider while Vbb and DB are still using AbstractHafasLegacyProvider. There might be a "bug" in the new provider when using addresses like Transportr does. You can ask on their mailing list: https://groups.google.com/forum/#!forum/public-transport-enabler-discuss

[tbertels]

The same problem happens in Liège, Belgium: when tapping on the map on "Place Saint-Lambert" as the destination, Transportr makes us go to the "Place Saint-Lambert" in Jodoigne.

[ialokim]

The BvgProvider uses the new AbstractHafasMobileProvider while Vbb and DB are still using AbstractHafasLegacyProvider. There might be a "bug" in the new provider when using addresses like Transportr does.

As DB and VBB are now also using AbstractHafasClientInterfaceProvider, it would be interesting to know if this problem now also happens using these two providers.

[knttr]

GPS shows me at "Rue Pierre de Coubertin" in Brunstatt near Mulhouse in France, which is correct. I use this as starting point to travel to Munich. Transporter 2.1.3 sets the starting point to Rue Pierre de Coubertin in Luxembourg.

When setting Mulhouse Ville as starting point, the route is correct. (Connection from Mulhouse via Basel, Karlsruhe and Munich)

In both cases I used the DB (Deutsche Bahn) router (?).

[Mannshoch]

Same Problem with SBB Switzerland. If i choose a point on the map and start a search. Normally I get the route from a street with the same name but somwhere in Switzerland. Currently Transporter not work from the Map in Switzerland.