Skip to content

Frameworks are not all Rails #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Frameworks are not all Rails #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
414909a
Remove block on Rails > 5
pboling Feb 1, 2021
8c731bd
Not everything is Rails!
pboling Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/test_after_commit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
require 'test_after_commit/version'

if ActiveRecord::VERSION::MAJOR >= 5
raise 'after_commit testing is baked into rails 5, you no longer need test_after_commit gem'
end

if ActiveRecord::VERSION::MAJOR >= 4
require 'test_after_commit/with_transaction_state'
ActiveRecord::Base.send(:prepend, TestAfterCommit::WithTransactionState)
Expand Down
2 changes: 1 addition & 1 deletion test_after_commit.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Gem::Specification.new name, TestAfterCommit::VERSION do |s|
s.license = 'MIT'

s.required_ruby_version = '>= 2.0.0'
s.add_runtime_dependency "activerecord", [">= 3.2", "< 5.0"]
s.add_runtime_dependency "activerecord", ">= 3.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be < 7.1 and add the missing gemfiles
(can remove all the old 4.x gemfiles)
and update the readme to say that this makes sense for non-rails only

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do


s.add_development_dependency "wwtd"
s.add_development_dependency "bump"
Expand Down