Skip to content

Commit

Permalink
drop ruby 2.7 since rails 6 test no longer runs with that
Browse files Browse the repository at this point in the history
  • Loading branch information
grosser committed May 20, 2024
1 parent 8e8092f commit 1aabc81
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ jobs:
strategy:
fail-fast: false # run all tests so we see which gem/ruby combinations break
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', head, jruby-head]
ruby: ['3.0', '3.1', '3.2', '3.3', head, jruby-head]
os: [ubuntu-latest, windows-latest]
task: [spec]
include:
- ruby: '2.7' # lowest supported version, same as gemspec and .rubocop.yml
- ruby: '3.0' # lowest supported version, same as gemspec and .rubocop.yml
os: ubuntu-latest
task: rubocop
steps:
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
AllCops:
NewCops: enable
TargetRubyVersion: 2.7
TargetRubyVersion: 3.0
SuggestExtensions: false
Exclude:
- '**/vendor/bundle/**/*'
Expand Down
2 changes: 1 addition & 1 deletion lib/parallel_tests.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def pid_file_path

def stop_all_processes
pids.all.each { |pid| Process.kill(:INT, pid) }
rescue Errno::ESRCH
rescue Errno::ESRCH, Errno::EPERM
# Process already terminated, do nothing
end

Expand Down
2 changes: 1 addition & 1 deletion parallel_tests.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ Gem::Specification.new name, ParallelTests::VERSION do |s|
s.license = "MIT"
s.executables = ["parallel_spinach", "parallel_cucumber", "parallel_rspec", "parallel_test"]
s.add_runtime_dependency "parallel"
s.required_ruby_version = '>= 2.7.0'
s.required_ruby_version = '>= 3.0.0'
end
2 changes: 1 addition & 1 deletion spec/fixtures/rails61/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ gem 'activesupport', rails_version
gem 'railties', rails_version
gem 'sprockets-rails'

gem 'sqlite3', '~> 1.7.3' # last before 2.0
gem 'sqlite3', '~> 1.7.3' # last before 2.0 which has weird install errors
gem 'tzinfo-data'
gem 'parallel_tests', path: "../../../", group: :development
2 changes: 1 addition & 1 deletion spec/fixtures/rails70/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ gem 'activerecord', rails_version
gem 'activesupport', rails_version
gem 'railties', rails_version

gem 'sqlite3', '~> 1.7.3' # last before 2.0
gem 'sqlite3', '~> 1.7.3' # last before 2.0 which has weird install errors
gem 'tzinfo-data'
gem 'parallel_tests', path: "../../../", group: :development

0 comments on commit 1aabc81

Please sign in to comment.