Skip to content

refactor(about): remove unused dependencies #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gromif merged 4 commits into from
Jun 30, 2025
Merged

refactor(about): remove unused dependencies #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b14cb73
refactor(about): move `Params` to `model` package
gromif Jun 30, 2025
0161ced
refactor(about): make `Screen` internal
gromif Jun 30, 2025
46ee11e
refactor(about): remove unused dependencies
gromif Jun 30, 2025
d381b01
chore(ide): introduce code scope for `About` feature
gromif Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/scopes/Feature__About.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions features/about/fdroid/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,4 @@ android {
dependencies {
implementation(projects.features.about)
implementation(projects.ui.resources)

implementation(libs.androidx.core.ktx)

testImplementation(libs.junit)
androidTestImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.espresso.core)
}
1 change: 1 addition & 0 deletions features/about/fdroid/src/main/java/io/gromif/astracrypt/settings/about/AboutScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.res.stringResource
import io.gromif.astracrypt.resources.R
import io.gromif.astracrypt.settings.about.model.Link
import io.gromif.astracrypt.settings.about.model.Params
import io.gromif.astracrypt.settings.about.shared.PredefinedLinks

@Composable
Expand Down
6 changes: 0 additions & 6 deletions features/about/google-play/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,4 @@ android {
dependencies {
implementation(projects.features.about)
implementation(projects.ui.resources)

implementation(libs.androidx.core.ktx)

testImplementation(libs.junit)
androidTestImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.espresso.core)
}
1 change: 1 addition & 0 deletions features/about/google-play/src/main/java/io/gromif/astracrypt/settings/about/AboutScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.res.stringResource
import io.gromif.astracrypt.resources.R
import io.gromif.astracrypt.settings.about.model.Link
import io.gromif.astracrypt.settings.about.model.Params
import io.gromif.astracrypt.settings.about.shared.PredefinedLinks

@Composable
Expand Down
1 change: 1 addition & 0 deletions features/about/src/main/java/io/gromif/astracrypt/settings/about/About.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.tooling.preview.Preview
import io.gromif.astracrypt.settings.about.extensions.start
import io.gromif.astracrypt.settings.about.model.Link
import io.gromif.astracrypt.settings.about.model.Params
import kotlinx.coroutines.CoroutineScope

@Preview(showBackground = true)
Expand Down
3 changes: 2 additions & 1 deletion features/about/src/main/java/io/gromif/astracrypt/settings/about/Screen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@ import androidx.compose.ui.tooling.preview.Preview
import io.gromif.astracrypt.resources.R
import io.gromif.astracrypt.settings.about.list.LinkList
import io.gromif.astracrypt.settings.about.model.Link
import io.gromif.astracrypt.settings.about.model.Params
import io.gromif.astracrypt.settings.about.shared.CardLinkList
import io.gromif.astracrypt.settings.about.shared.Header
import io.gromif.ui.compose.core.PreferencesGroup
import io.gromif.ui.compose.core.PreferencesScreen

@Preview(showBackground = true)
@Composable
fun Screen(
internal fun Screen(
params: Params = Params(),
onLinkClick: (Link) -> Unit = {},
) = PreferencesScreen {
Expand Down
3 changes: 1 addition & 2 deletions ...romif/astracrypt/settings/about/Params.kt → ...astracrypt/settings/about/model/Params.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.gromif.astracrypt.settings.about
package io.gromif.astracrypt.settings.about.model

import io.gromif.astracrypt.settings.about.list.FakeData
import io.gromif.astracrypt.settings.about.model.Link

data class Params(
val version: String = "<VERSION>",
Expand Down