-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adds require serial as Asset Model option #16947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Godmartinz
wants to merge
13
commits into
grokability:develop
Choose a base branch
from
Godmartinz:add-require-serial-to-models
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds require serial as Asset Model option #16947
Godmartinz
wants to merge
13
commits into
grokability:develop
from
Godmartinz:add-require-serial-to-models
+187
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uberbrady
reviewed
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably have a few things to talk about in there, but this is very clean code, very well-executed. Let's chat more offline and see if we want to embed in other stuff or take this as-is.
database/migrations/2025_05_12_183803_add_req_serial_bool_to_models_table.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives users the option to require serials by asset model.


This can be done via each model individually, or through bulk editing models
Model edit:
Bulk Model edit:
I was concerned with "What if you update an asset model to require serials, how do we deal with that retroactively?" My solution is not to make validation fail if you update an asset w/o a serial, but to provide a 'warning' message that that asset needs a serial appended. it is an undertaking that a user should be prepared to fill.
Asset Update:

(If a bad user deletes the serial, that info is readily available in the history log of the asset.)
Moving forward with asset creation, if the Asset model selected requires a serial, a form validation will fire:

Require Serial Number is also a sortable field in the Asset Models index:

Tests have been included.