-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Refactors Low Inventory Alert Notification to Mailable #16444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Refactors Low Inventory Alert Notification to Mailable #16444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one question about the AllowDynamicProperties
attribute.
Can we delete App\Notifications\InventoryAlert
in the PR as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏾
Can you remind me why we're using Mailable here? Notifications were the way we used to do these and I don't recall why we suddenly needed to change these. |
refactors the low inventory alert notification to a mailable and adds tests too.