Skip to content

Refactors Low Inventory Alert Notification to Mailable #16444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Member

refactors the low inventory alert notification to a mailable and adds tests too.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one question about the AllowDynamicProperties attribute.

Can we delete App\Notifications\InventoryAlert in the PR as well?

@Godmartinz Godmartinz requested a review from marcusmoore March 6, 2025 19:43
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@Godmartinz Godmartinz changed the title refactorss Low Inventory Alert Notification to Mailable Refactors Low Inventory Alert Notification to Mailable Mar 6, 2025
@snipe
Copy link
Member

snipe commented Jun 23, 2025

Can you remind me why we're using Mailable here? Notifications were the way we used to do these and I don't recall why we suddenly needed to change these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants