Gaia 20182 Increase read chunksize on iterlines() and remove chunksize from stream_data_series() #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabesh-paudel
requested review from
muzigao-gro,
cn1036,
HonghuiLu2021 and
John-Desmond
HonghuiLu2021
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
The sdk was slow and had adjustable
chunk_size(not the read chunk size, but the param to determine how many dataseries to be yielded on each iteration ofstream_data_series()) parameter.Solution:
Increase the read chunksize of
iter_lines()to 4 MB. And remove thechunk_sizeparam fromstream_data_series()while setting it fixed at10kdataseries.Tested:
Tested in local.