DELI-276 include historical refactor for get_descendant() #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cn1036
reviewed
Feb 16, 2022
groclient/lib.py
Outdated
| @@ -675,20 +675,16 @@ def get_descendant(access_token, api_host, entity_type, entity_id, distance=None | |||
| else: | |||
| params['distance'] = -1 | |||
|
|
|||
| if not include_historical: | |||
There was a problem hiding this comment.
minor: can simply use params['includeHistorical'] = include_historical
cn1036
suggested changes
Feb 16, 2022
cn1036
approved these changes
Feb 16, 2022
|
waiting for the prod release |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
muzigao-gro
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously get_descendant() made a call to
v2/regions/containsto get the descendant ids for a given region, then if include_historical was set to false, it would do batch lookups of the descendant ids against thev2/regionsendpoint. After getting a response, it would filter the data for the regions that had include_historical set to false.This PR is directly related to the DELI-276 PR on the
gro/apicode base, where the includeHistorical parameter was added to the/v2/reginos/containsendpoint as an optional parameter. Thus, now the filtering for the historical regions is done at the DB level, and unnecessary processing at the python API client is no longer necessary.