Skip to content

If a space character has been escaped in the database filename path (… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

If a space character has been escaped in the database filename path (… #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e45c14
If a space character has been escaped in the database filename path (…
joulupukki Oct 13, 2017
c720736
Make sure to replace ALL (global) '%20' occurrences with a space char…
joulupukki Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parse-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ module.exports = function parseDbUrl (dbUrl) {
// Trim leading slash for non-sqlite3 databases
if (adapter !== 'sqlite3' && database) {
var database = database.substring(1)
} else if (adapter == 'sqlite3' && database) {
// Remove any '%20' with real spaces so the database
// path is a true file path that the sqlite3 adapter
// can use (i.e., /Users/jdoe/Library/Application Support/myapp/mydatabase.sqlitedb)
// Fixes: https://github.com/grncdr/parse-db-url/issues/1
var database = database.replace(/\%20/g, ' ')
}

if (parsed.port) {
Expand Down