Add manifest validation events handling #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rebar3_grisp_pack.erl
Outdated
| event([pack, package, extract_manifest, {error, Reason}]) -> | ||
| abort_message("Failed to extract software manifest", Reason); | ||
| event([pack, package, extract_manifest, {manifest, undefined}]) -> | ||
| console(" Software manifest not found !"); |
There was a problem hiding this comment.
Is it an error/warning message ? It should maybe use warn/2 for it
sylane
force-pushed
the
sylane/pack-manifest-events
branch
from
fb6ef62 to
246ed05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changed that are required to properly show the status of manifest validation during the pack command. This is needed by a PR already merged in grisp_tools but I forgot to push the changes in rebar3_grisp. As this is a bit old, it would be best if you validate that this is still working for you with the last main of grisp_tools, that the pack command is working as expected and showing the proper messages when run.