Skip to content

Patch tests for compatibility with xtb 6.4.X #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Patch tests for compatibility with xtb 6.4.X #60

wants to merge 1 commit into from

Conversation

jan-janssen
Copy link

Description

With xtb 6.3.3 the tests work fine but with 6.4.1 they failed with the following error message:

>       assert approx(atomic_result.properties.scf_dipole_moment, abs=thr) == dipole_moment
E       assert approx([0.33451151977076465 ± 1.0e-07, -1.0701017905608206 ± 1.0e-07, -1.229921234359929 ± 1.0e-07]) == array([ 0.3345064 , -1.07009252, -1.22991954])
E         +approx([0.33451151977076465 ± 1.0e-07, -1.0701017905608206 ± 1.0e-07, -1.229921234359929 ± 1.0e-07])
E         -array([ 0.3345064 , -1.07009252, -1.22991954])

../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/xtb/qcschema/test_qcschema.py:73: AssertionError
=========================== short test summary info ============================
FAILED qcschema/test_qcschema.py::test_gfn2xtb_energy - assert approx([0.3345...
======================== 1 failed, 29 passed in 10.16s =========================

The issue appeared during building the conda package: conda-forge/xtb-python-feedstock#12

Changelog description

I updated the tests to included the updated values from xtb 6.4.1.

Status

@awvwgk
Copy link
Member

awvwgk commented Dec 2, 2021

Needs #62 and #61 to get the repo working again

@awvwgk awvwgk deleted the branch grimme-lab:master January 31, 2022 20:06
@awvwgk awvwgk closed this Jan 31, 2022
@awvwgk awvwgk mentioned this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants