Repository navigation
onStartMoving() fix to minHeight (#999) - #1035
Merged
Merged
Conversation
added 2 commits
November 11, 2019 15:40
*method was not correctly counting margin when figuring out minHeight during a drag (see #999) * fixed cellHeight() getter to correctly returns the value and checked all places that use to adjust for margins
Member
|
|
Member
Author
|
@radiolips I changed one of the demo (two.html) to have Now mind you we fail to convert the units to actual pixels so '2rem' = '2px' = '2em' = 2 which is clearly incorrect, but that's a separate issue (maybe the CSS is update for other values, but verticalMargin is pixel code and therefore wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
*method was not correctly counting margin when figuring out minHeight during a drag
(see #999)
Checklist
yarn test)I tested two.html as well as my app that doesn't a lot of drag&drop and made sure things resized correctly and no new issue, but min size is now correct (see #999 screen shots)