Skip to content

setStatic not working! #481

Closed
Closed

Description

@artknight

I peeked at the source and I am seeing this code that seems to prevent the grid to be made static

 if (self.opts.staticGrid || typeof node == 'undefined' || node === null) {
                return;
            }

self.opts.staticGrid is set to true so this will return before doing anything

Activity

  1. radiolips commented on Jul 30, 2016

    @radiolips
    Member

    You're right. It looks like #431 broke this functionality. I'm pleased the jQuery-ui requirement was removed, but unfortunately it only accounted for static being set initially and not dynamically changed. We'll probably end up rolling back the change set. Thanks for identifying this.

  2. added this to the v0.2.6 milestone on Aug 16, 2016
  3. added a commit that references this issue on Aug 16, 2016
    696b0f7
  4. radiolips commented on Aug 16, 2016

    @radiolips
    Member

    @artknight This should be fixed in v.0.2.6. Could you let me know? It should still make sure jquery-ui is not a requirement, but should now work if you modify setStatic at any time.

  5. radiolips commented on Sep 6, 2017

    @radiolips
    Member

    @artknight I have no idea if this was fixed Aug 16, 2016, but it should be fixed now. setStatic was working, but staticGrid was not. And now it does work.

  6. artknight commented on Sep 6, 2017

    @artknight
    Author

    this is fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions