Repository navigation

directionCollideCoverage doesn't find most overlapping node #2435

Closed

opened

Found while working on the code...

overMax needs to be moved outside of the forEach so that directionCollideCoverage returns the node with the most overlap, rather than the last node with >50% overlap

https://github.com/gridstack/gridstack.js/blame/32337b63be0799161f9fd2a763db901c569c3383/src/gridstack-engine.ts#L165

adumesny
added a commit that references this issue on Sep 5, 2023
directionCollideCoverage() tweaks
a747df5
adumesny
closed this as completedin #2440 on Sep 5, 2023
adumesny commented on Sep 5, 2023
adumesny
on Sep 5, 2023
Member
hey thanks, yep makes sense.

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests