Repository navigation
Bugs with new fitToContent (1rem, calling cellHeight) #2427
Description
Subject of the issue
Issue 1: fitToContent / misbehaving not working when cellHeight is not an integer (1rem support) FIXED
Issue 2: Starting with column 2, then changing the cellHeight, then changing the column to 1 will revert it back to 2 column
Issue 3: Changing cellHeight will not auto size the cell to content height FIXED
NOTE: This may not be a bug and may be intended behavior, i.e call resizeToContent on cellHeight() call
Issue 4: Clicking add widget will not auto size the cell to the content height (added makeWidget version too because this is my typical flow) FIXED
NOTE: This may not be a bug and may be intended behavior, i.e call resizeToContent on widget add (addWidget or makeWidget)
Your environment
Gridstack Version 9.0.1 (using gridstack.extra.css)
Google Chrome, Edge
Steps to reproduce
https://jsfiddle.net/zxwg5j7m/101/
Issue 1 + 3
Issue 2
Issue 4
Expected behavior
Cell should fit to content,
addWidget / makeWidget should auto size the cell
cellHeight should auto size the cell
Activity
adumesny commentedon Aug 29, 2023
not surprised 1rem doesn't work. as for 3 & 4 changing cellHeight (with a px number) and adding widget/makeWidget should call resizeToContent(). that's a bug.
Funny the only time I head from people is when a big new feature has bugs and people apparently start using it right away...
#404 has been 7 years in the making :)
[-]Bugs with new fitToContent feature[/-][+]Bugs with new fitToContent (rem, calling cellHeight, addWidget/MakeWidget)[/+]ExusAltimus commentedon Aug 29, 2023
This is by far the best project I have found for dashboard-style widgets, other libraries don't have nearly all the features that this one does. I was also using a custom solution for resizing right before this came out so I decided to swap over and try it out. I've been slowly getting familiar with the code base so next time I run into something I'll put some effort into looking into a fix
adumesny commentedon Aug 29, 2023
yeah, fitToContent is something my current project at work was needing (all previous were stretch to fit gridItem instead as mostly graphs) and after having it solved there I decided move the code to GS as I will possibly make live resizing be aware of fitToContent.
I actually need to support having a user size vs fitting to content as sometimes content is smaller so no need to waste space, but them max at user settable size when the content is too big (dynamic content), so big new feature still comming...
fitToContent when calling cellHeight()/addWidget/MakeWidget
fitToContent when calling cellHeight()/addWidget/MakeWidget
adumesny commentedon Aug 29, 2023
item 3 and 4 are now fixed. others will have to wait...
[-]Bugs with new fitToContent (rem, calling cellHeight, addWidget/MakeWidget)[/-][+]Bugs with new fitToContent (1rem, calling cellHeight)[/+]rem/em support for sizeToContent
adumesny commentedon Dec 10, 2023
closing. # 2 is separate issue and should be filed if still present.
Don't forget to donate if you find this lib useful!