Skip to content

Gridstack from v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value  #2357

Closed

Description

@zsolt-horvath

Subject of the issue

From version 8 and above gridstack produces a weird, hard to debug "maximum call stack size exceeded" error and crashes the whole page when cellHeight is set with "rem". It is working properly with v7

Steps to reproduce

You can reproduce it in with the gridstack repo.

In the Gridstack repo go to: angular -> projects -> demo -> src -> app -> app.component.ts
Add for example: cellHeight: '23rem' to gridOptions in line # 36
Run the app locally, select the proper demo and try to drag&drop one of the grid items

Activity

  1. changed the title [-]Gridstack > v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value [/-] [+]Gridstack from v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value [/+] on Jun 5, 2023
  2. adumesny commented on Jun 12, 2023

    @adumesny
    Member

    I'm not seeing any issue with 8.2.1 - I can drag items just fine (they don't resize though)
    image

  3. adumesny commented on Jun 12, 2023

    @adumesny
    Member

    Oh never mind - draging the first item to push the other does cause issues...

  4. added a commit that references this issue on Jun 12, 2023
    d75627d
  5. adumesny commented on Jun 12, 2023

    @adumesny
    Member

    took a while to debug - though simple 1 liner fix.

    fixed in next release. don't forget to donate if you find this lib useful!

  6. zsolt-horvath commented on Jun 12, 2023

    @zsolt-horvath
    Author

    Thank your for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions