Add Widget bug #20

Activity

1. troolee commented on Dec 4, 2014

   

   troolee

   on Dec 4, 2014

   Member

   More actions

   Can you give a sample?
2. ashishpadave commented on Dec 4, 2014

   

   ashishpadave

   on Dec 4, 2014

   Author

   More actions

   I have used the demo html and added the following script and a button.

   <input id="add_widget" type="button" value="Add Widget" style="color:#000"/>

   <script type="text/javascript">
               $(function() {
                   $('.grid-stack').gridstack({
                       width: 12,
                       height:10,
                       cell_height: 50,
                       vertical_margin: 5,
                   });
               });
   
               $('#add_widget').click(function(){
                   var el = $.parseHTML("<div><div class=\"grid-stack-item-content\"/><div/>");
                   var grid = $('.grid-stack').data('gridstack');
                   grid.add_widget(el, 1, 1, 4, 1, true);
               });
   </script>

   If i keep clicking the add_widget button, the widgets continue to get added beyond the max number of rows.
3. ashishpadave commented on Dec 4, 2014

   

   ashishpadave

   on Dec 4, 2014

   Author

   More actions

   http://screencast.com/t/IGZ9txKZYh

   Notice that the first item is added on the right and its bigger than the max _width defined. While the last item that is added at the bottom is also beyond the height limit.
4. troolee

   added this to the 0.2.1 milestone on Dec 4, 2014
5. troolee commented on Dec 4, 2014

   

   troolee

   on Dec 4, 2014

   Member

   More actions

   Thank you for feedback.

   I will check auto positioning. Also I will add a method which will help to check if a widget could be added with respect to vertical constraint. I don't think that height property should restrict from adding.
6. ashishpadave commented on Dec 4, 2014

   

   ashishpadave

   on Dec 4, 2014

   Author

   More actions

   If height is not explicitly defined then the height property should not be restrictive. But if someone has defined the height then the add_widget should definitely restrict or at least warn the user that the new widget is being added beyond the set width / height restrictions.
7. troolee commented on Dec 6, 2014

   

   troolee

   on Dec 6, 2014

   Member

   More actions

   I've fixed the bug with auto-positioning. I've also added a new method will_it_fit. You have to check by yourself before add a widget. Please see the README.md.
8. troolee

   closed this as completedon Dec 6, 2014
9. ashishpadave commented on Dec 9, 2014

   

   ashishpadave

   on Dec 9, 2014

   Author

   More actions

   Thank you :)