alwaysShowResizeHandle does not work anymore in v2.0.0 #1373

Activity

1. adumesny commented on Sep 27, 2020

   

   adumesny

   on Sep 27, 2020

   Member

   More actions

   I'm not seeing this issue on Chrome/Windows 10. please provide what browser and with 1.21.1 vs 2.0.0 as maybe your browser doesn't support these

       var grid = GridStack.init({
         alwaysShowResizeHandle: /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(
           navigator.userAgent
         ),
         resizable: {
           handles: 'e, se, s, sw, w'
         },

   
2. adumesny

   closed this as completedon Sep 27, 2020
3. adumesny

   added

   status:need more info

   on Sep 27, 2020
4. loedeman commented on Sep 28, 2020

   

   loedeman

   on Sep 28, 2020

   Author

   More actions

   Sorry, but your screenshot shows the problem exactly. In my screenshot, I circled all resize handles which should NOT be visible, unless HOVERED.

   

   Imho, immediately closing an issue is not that friendly too by the way. I will think twice now before reporting another issue.
5. loedeman commented on Sep 28, 2020

   

   loedeman

   on Sep 28, 2020

   Author

   More actions

   BTW, I am using the latest version of Chrome (85.0.4183.121) on the latest version of Windows 10. I already explicitly stated that I was using Gridstack 2.0.0 and that the issue applies to all browsers.
6. adumesny commented on Sep 28, 2020

   

   adumesny

   on Sep 28, 2020

   Last edited by adumesny

   Member

   More actions

   Please re-read your bug report. You said "alwaysShowResizeHandle does not work anymore" then you point to my example which does show the resize handles in all corners as stated in the code, while other demos do show on hover only (don't have that flag turned on).

   You didn't bother copying the bug template and modifying to show an actual bug, but expect me to debug it for you ???
   a lot of people file bugs when it's user error, then don't get back to me, and I don't have the bandwidth to debug it. It's simple enough to re-open when you actually have a reproduceable case.

   then in your later comment you say "In my screenshot, I circled all resize handles which should NOT be visible, unless HOVERED." then you must be turning that feature off - how am I supposed to know what you mean ?

   | I will think twice now before reporting another issue.

   what do you expect ? this is a free lib and I didn't see you contribute time or $ (there is a donate button in case you missed it). I spent a LOT of personal time maintaining this lib and you didn't file a reproduceable bug. Thank you for taking 20min of my time this morning debugging it for you twice now.

   Note to self: apparently this flag define IF the handles are always visible or not, instead of alwaysShowResizeHandle . Not sure if new in 2.x

   resizable: { handles: 'e, se, s, sw, w' }
7. adumesny

   reopened this on Sep 28, 2020
8. adumesny

   removed

   status:need more info

   on Sep 28, 2020
9. adumesny

   added a commit that references this issue on Oct 6, 2020

   fix setting resize handles to not alwaysShowResizeHandle

   ...

   97a8426
10. adumesny commented on Oct 6, 2020

    

    adumesny

    on Oct 6, 2020

    Member

    More actions

    fixed in next release
11. adumesny

    closed this as completedon Oct 6, 2020
12. loedeman commented on Oct 6, 2020

    

    loedeman

    on Oct 6, 2020

    Author

    More actions

    Thanks!
13. adumesny

    added a commit that references this issue on Oct 6, 2020

    v2: fix setting resize handles to not alwaysShowResizeHandle

    ...

    c0eb525