Resizing does not work as expected #1166

Activity

1. awjae commented on Feb 26, 2020

   

   awjae

   on Feb 26, 2020

   Contributor

   More actions

   Temporary Quick Solution

   Check gridstack.all.js cdn file
   https://cdn.jsdelivr.net/npm/gridstack@1.0.0/dist/gridstack.all.js

   Edit function
   function t(e, t) { f.$el.append(f.placeholder); var i = g(this); f.engine.cleanNodes(), f.engine.beginUpdate(u), d = f.cellWidth(); var n = f.cellHeight(); c = f.$el.height() / parseInt(f.$el.attr("data-gs-current-row")), f.placeholder.attr("data-gs-x", i.attr("data-gs-x")).attr("data-gs-y", i.attr("data-gs-y")).attr("data-gs-width", i.attr("data-gs-width")).attr("data-gs-height", i.attr("data-gs-height")).show(), u.el = f.placeholder.get(0), u._beforeDragX = u.x, u._beforeDragY = u.y, u._prevYPix = t.position.top; var o = u.minHeight || 1, s = f.opts.verticalMargin; f.dd.resizable(h, "option", "minWidth", d * (u.minWidth || 1)), f.dd.resizable(h, "option", "minHeight", n * o + (o - 1) * s), "resizestart" === e.type && i.find(".grid-stack-item").trigger("resizestart") }

   TO

   function t(e, t) { f.$el.append(f.placeholder); var i = g(this); f.engine.cleanNodes(), f.engine.beginUpdate(u), d = f.cellWidth(); var n = f.cellHeight(); c = (f.$el.height() + grid.verticalMargin()) / parseInt(f.$el.attr("data-gs-current-row")), f.placeholder.attr("data-gs-x", i.attr("data-gs-x")).attr("data-gs-y", i.attr("data-gs-y")).attr("data-gs-width", i.attr("data-gs-width")).attr("data-gs-height", i.attr("data-gs-height")).show(), u.el = f.placeholder.get(0), u._beforeDragX = u.x, u._beforeDragY = u.y, u._prevYPix = t.position.top; var o = u.minHeight || 1, s = f.opts.verticalMargin; f.dd.resizable(h, "option", "minWidth", d * (u.minWidth || 1)), f.dd.resizable(h, "option", "minHeight", n * o + (o - 1) * s), "resizestart" === e.type && i.find(".grid-stack-item").trigger("resizestart") }

   It change
   c = f.$el.height() / parseInt(f.$el.attr("data-gs-current-row"))
   ->
   c = (f.$el.height() + grid.verticalMargin()) / parseInt(f.$el.attr("data-gs-current-row"))

   
2. adumesny commented on Feb 26, 2020

   

   adumesny

   on Feb 26, 2020

   Last edited by adumesny

   Member

   More actions

   by the way you can use non min files (to help debug) like the git demos (just change to URL)

   <script src="../src/jquery.js"></script>
   <script src="../src/gridstack.js"></script>
   <script src="../src/jquery-ui.js"></script>
   <script src="../src/gridstack.jQueryUI.js"></script>
   

   You can also reproduce with our demo https://gridstackjs.com/demo/float.html
   Funny thing is I recall fixing a similar issue where margin wasn't taken into account before... maybe I missed that one, or got reverted???

   do you mind putting a code review fix ? that would be great!
3. adumesny

   added

   type:bug

   on Feb 26, 2020
4. awjae

   added a commit that references this issue on Feb 27, 2020

   gridstack#1166 issue fix

   c943199
5. adumesny

   closed this as completedin #1169on Feb 27, 2020
6. adumesny commented on Feb 27, 2020

   

   adumesny

   on Feb 27, 2020

   Member

   More actions

   fixed in next release