-
Notifications
You must be signed in to change notification settings - Fork 184
test: Add scheduler test coverage #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
barton2526
wants to merge
21
commits into
gridcoin-community:development
from
barton2526:wait_until_test
Closed
test: Add scheduler test coverage #2328
barton2526
wants to merge
21
commits into
gridcoin-community:development
from
barton2526:wait_until_test
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: James C. Owens <jamesowens@optonline.net>
Co-authored-by: div72 <60045611+div72@users.noreply.github.com>
Introduced in gridcoin-community#1888
|
The PR compiles, but the new test case is failing in an obscure way. It also appears to have passed on Windows 32 bit...? Perhaps it would be better to take boost out of the scheduler? |
qt: Replace deprecated Qt functions
qt: fix broken research wizard signal
build: set minimum required Boost to 1.60
cd: generate release binaries using GitHub actions
refactor: Fix three minor code scanner findings
…oin-Research into wait_until_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for the scheduler from upstream. The goal of this PR was initially to port bitcoin/bitcoin#18285, which adds a test case to catch bugs like this one #1887. While working I discovered we didn't test the scheduler at all, so let's get more coverage.
Ref: bitcoin/bitcoin@fa6bad2
Optional other tests include: