Skip to content

poll: Fix the possible infinite loop warning on GetChoices() in result.cpp #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021
Merged

poll: Fix the possible infinite loop warning on GetChoices() in result.cpp #2322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/gridcoin/voting/result.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,21 @@ class LegacyVoteCounterContext
const LegacyChoiceMap& GetChoices()
{
if (m_legacy_choices_cache.empty()) {
for (uint8_t i = 0; i < m_poll.Choices().size(); ++i) {
uint8_t m_poll_choices_size = 0;

// This silences the code scan warning of a possible infinite loop due to the overflow of the uint8_t i counter
// against the comparison to m_poll.Choices.size(). Note it is the logged equivalent to std::min<uint8_t>. Since
// this is legacy polls only and those are no longer issued, and this condition does not actually exist in the
// chain, this is purely for formality's sake.
if (m_poll.Choices().size() > (size_t) std::numeric_limits<uint8_t>::max()) {
LogPrintf("WARN: %s: Number of legacy poll choices exceeds bins available in m_legacy_choices_cache map. "
"Limiting to %u.", __func__, std::numeric_limits<uint8_t>::max());
m_poll_choices_size = std::numeric_limits<uint8_t>::max();
} else {
m_poll_choices_size = m_poll.Choices().size();
}

for (uint8_t i = 0; i < m_poll_choices_size; ++i) {
std::string label = m_poll.Choices().At(i)->m_label;
label = ToLower(label);

Expand Down