Fix tranlatable phrases and regenerate translation units #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbrod
reviewed
May 1, 2019
| @@ -392,8 +392,7 @@ bool CTxDB::LoadBlockIndex() | |||
| nLoaded +=10000; | |||
| if (nLoaded > nHighest) nHighest=nLoaded; | |||
| if (nHighest < nGrandfather) nHighest=nGrandfather; | |||
| std::string sBlocksLoaded = ToString(nLoaded) + "/" + ToString(nHighest) + " Blocks Loaded"; | |||
| uiInterface.InitMessage(_(sBlocksLoaded.c_str())); | |||
| uiInterface.InitMessage(strprintf("%" PRId64 "/%" PRId64 " %s", nLoaded, nHighest, _("Blocks Loaded"))); | |||
There was a problem hiding this comment.
bad string format. Some languages require the number between blocks and loaded.
There was a problem hiding this comment.
Yeah, unfortunately _(...) doesn't provide a way to pass arguments for placeholder variants like tr(...) does, but it looks like we only use tr() in the GUI code. We could expand the uiInterface to support that later, maybe...
There was a problem hiding this comment.
Ok. Do not worry about it. This is good enough.
tomasbrod
approved these changes
May 1, 2019
jamescowens
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We briefly touched on translations in #1447, so I'm pushing this for closer review. I fixed the code from that PR to work idiomatically with Qt's translation system, updated a couple other locations that contained un-translatable expressions in
_(...)calls (90a57e9), and regenerated the translation units (a97e2b5). This pruned some entries that don't exist today, fixed a few that we never updated, and added new entries that were missing for the Scraper, side staking, and the changes in the previous PR.Might be good to do this each time a release cycle ends. Hopefully it encourages more participation from translators.