Improvements to the polytopal and hybrid methods API#1218
Open
JordiManyer wants to merge 67 commits intomasterfrom
Open
Improvements to the polytopal and hybrid methods API#1218JordiManyer wants to merge 67 commits intomasterfrom
JordiManyer wants to merge 67 commits intomasterfrom
Conversation
Add check to skip UNSET entries in inverse_table function to prevent invalid array access. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ocal faces and dofs
The old code does not work when you have more than 4 faces being incident on a single vertex. The new version should be more robust.
…m UnstructuredDiscreteModels
JordiManyer
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
- Coverage 89.04% 87.19% -1.85%
==========================================
Files 213 214 +1
Lines 27530 28122 +592
==========================================
+ Hits 24514 24522 +8
- Misses 3016 3600 +584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Table, following theSparseArraysmodel. Mainly, we introducedatarange,dataviewanddataiteratorfunctions. Since PR#1218.set_local_integer_typeis introduced, which sets a new typeGridapLocalInt(defaultInt8) that is set at compile time. This allows forGeneralPolytopeswith an arbitrary number of faces. Since PR#1218.compute_graphreturning the face-connectivity of meshes and submeshes. Since PR#1218.MultiFieldFEBasisComponentandMultiFieldBasishave now new constructors that easily allow to recast a multi-field space with a different block structure. Since PR#1218.GeneralPolytopes, addedis_convex,signed_area,signed_volume,convexify(2D),extrude, as well as several low-level functions to manipulate polytopes. We now compute normals using Newel's algorithm, which is more stable. Since PR#1218.Changed
CellConformityAPI to be more flexible and extensible, while optimizing certain parts.CellConformityis now abstract, with new concrete typesGenericCellConformity(stores generic arrays),CompressedCellConformity(stores compressed data optimized for low number of reffe types, oldCellConformity), andDiscontinuousCellConformity(DG-type conformity, much faster for discontinuous spaces). For all new conformities, I have introduced a new API to query dof masks based on the faces dofs belong to, mainlygenerate_cell_dof_maskandgenerate_dof_mask. Since PR#1218.Fixed
face_labeling_from_cell_tags. Since PR#1218.