Skip to content

Conversation

@Antoinemarteau
Copy link
Contributor

@Antoinemarteau Antoinemarteau commented Dec 4, 2025

I noticed that some polytope docstrings were wrong regarding the definition of the D parameter of Polytope{D} (it's not the embedding dimension).

So I improved the docs and made num_point_dims(::Polytope) abstract because the result depend on the polytope implementation.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (fb5235b) to head (d201988).

Files with missing lines Patch % Lines
src/ReferenceFEs/ExtrusionPolytopes.jl 0.00% 1 Missing ⚠️
src/ReferenceFEs/Polytopes.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   89.31%   89.31%   -0.01%     
==========================================
  Files         212      212              
  Lines       27013    27014       +1     
==========================================
  Hits        24128    24128              
- Misses       2885     2886       +1     
Flag Coverage Δ
drivers 0.00% <0.00%> (ø)
extensions 0.00% <0.00%> (ø)
tests 89.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant