-
Notifications
You must be signed in to change notification settings - Fork 107
Misc TensorValue indexing improvements. #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support for indexing with `Colon()`/`:`, `end`, `::StaticArray`, `SOneTo`, and `::Array` - support for `axes` and `keys` - fixed `lastindex(a,d)`, `eachindex(::IndexStyle, a)` - changed `eachindex` and `CartesianIndices` to return `StaticArrays.SOneTo` instead of `Base.OneTo` - consistency with StaticArrays: the return value is statically typed (a scalar or `MultiValue`) iff all indices are statically inferable, otherwise an `Array` is returned. eachindex could still be optimized for tensor types that store all its physical components (no dependant or / statically known components) by switchin to `IndexLinear()` style.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 89.27% 89.30% +0.02%
==========================================
Files 211 211
Lines 26692 26710 +18
==========================================
+ Hits 23829 23853 +24
+ Misses 2863 2857 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This is merge-able, closes #1160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at
MultiValueindexing in detail to address #1160.Colon()/:,end,::StaticArray,UnitRanges,::SOneTo, and::Arraykeyslastindex(a,d),eachindex(::IndexStyle, a)eachindexandCartesianIndicesto returnStaticArrays.SOneToinstead ofBase.OneToMultiValue) iff all indices are statically inferable, otherwise anArrayis returned.E.g:
Also, I added new constructors for
MultiValue(sub)types takingSArray/MArrays andSArray/MArray's andArray's constructors takingMultiValueobjects that use the existing associatedconvertmethods. The advantage is you don't need to specify the exact size of the returned value, it's inferred from the argumentbut you can also specify struct arguments if you want to be sure of what you get or convert components