Add eigen function support for TensorValue #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #1156 where eigen() function did not work correctly with TensorValue objects. Changes: - Add eigen import and export to TensorValues module - Implement eigen(::MultiValue{Tuple{D,D}}) that delegates to StaticArrays - Add proper error handling for non-square matrices - Add comprehensive tests for various tensor types (TensorValue, SymTensorValue, SymTracelessTensorValue) - Test 1x1, 2x2, and 3x3 matrices with floating-point types - Test error handling for non-square matrices The implementation follows the same pattern as other LinearAlgebra operations like det() and inv() by using get_array() to convert to StaticArrays format and delegating to the optimized StaticArrays eigen implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add changelog entry for the new eigen function support for TensorValue objects. References issue #1156 and PR #1157. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
=========================================
Coverage ? 89.27%
=========================================
Files ? 211
Lines ? 26693
Branches ? 0
=========================================
Hits ? 23830
Misses ? 2863
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1156 where eigen() function did not work correctly with TensorValue objects.
The implementation follows the same pattern as other LinearAlgebra operations like det() and inv() by using get_array() to convert to StaticArrays format and delegating to the optimized StaticArrays eigen implementation.