Skip to content

Markup #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2015
Merged

Markup #37

merged 1 commit into from
Feb 20, 2015

Conversation

@HN23
Copy link
Contributor

@HN23 HN23 commented Oct 2, 2014

This is my latest attempt at oembedding and markup using pyembed, markdown, and BeautifulSoup

SeanHayes
SeanHayes reviewed Dec 30, 2014
View reviewed changes
django_mesh/models.py Outdated
Copy link
Member

@SeanHayes SeanHayes Dec 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use constants.

@SeanHayes
Copy link
Member

SeanHayes commented Jan 6, 2015

http://stackoverflow.com/a/6883094/241955

@HN23
Copy link
Contributor Author

HN23 commented Jan 7, 2015

made some fixes, squashed commits

SeanHayes
SeanHayes reviewed Feb 14, 2015
View reviewed changes
django_mesh/models.py Outdated
Copy link
Member

@SeanHayes SeanHayes Feb 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use this instead: https://docs.djangoproject.com/en/1.7/ref/utils/#django.utils.html.escape

@coveralls
Copy link

coveralls commented Feb 19, 2015

Coverage Status

Coverage decreased (-0.18%) to 99.82% when pulling 7f0ea4c on HN23:markup into 8a42618 on greyside:master.

@coveralls
Copy link

coveralls commented Feb 19, 2015

Coverage Status

Coverage decreased (-0.35%) to 99.65% when pulling 71cedfe on HN23:markup into 8a42618 on greyside:master.

@coveralls
Copy link

coveralls commented Feb 19, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 27ba1cb on HN23:markup into 3776036 on greyside:master.

SeanHayes
SeanHayes reviewed Feb 19, 2015
View reviewed changes
django_mesh/tests/test_models.py Outdated
Copy link
Member

@SeanHayes SeanHayes Feb 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add blank line.

@coveralls
Copy link

coveralls commented Feb 20, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 34551d1 on HN23:markup into 3776036 on greyside:master.

@coveralls
Copy link

coveralls commented Feb 20, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 767c7a4 on HN23:markup into 3776036 on greyside:master.

@coveralls
Copy link

coveralls commented Feb 20, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 6b17a3f on HN23:markup into 3776036 on greyside:master.

@coveralls
Copy link

coveralls commented Feb 20, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 6b17a3f on HN23:markup into 3776036 on greyside:master.

SeanHayes added a commit that referenced this pull request Feb 20, 2015
@SeanHayes
Merge pull request #37 from HN23/markup
c1ff9ee 
Markup and Oembed
@SeanHayes SeanHayes merged commit c1ff9ee into greyside:master Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HN23 @SeanHayes @coveralls