Skip to content

Commit

Permalink
Merge pull request thedaviddias#217 from JeffreyATW/remove-role
Browse files Browse the repository at this point in the history
Remove "role" items from accessibility section
  • Loading branch information
thedaviddias authored Jan 24, 2018
2 parents 134ce68 + b31fccd commit aa722e8
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 60 deletions.
9 changes: 0 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -606,15 +606,6 @@ Minimum required xml markup for the `browserconfig.xml` file is as follows:

> * 📹 [Why headings and landmarks are so important -- A11ycasts #18](https://www.youtube.com/watch?v=vAAzdi1xuUY&index=9&list=PLNYkxOF6rcICWx0C9LVWWVqvHlYJyqw7g)
#### Landmarks

- [ ] **Role banner:** ![High][high_img] `<header>` has `role="banner"`.
- [ ] **Role navigation:** ![High][high_img] `<nav>` has `role="navigation"`.
- [ ] **Role main:** ![High][high_img] `<main>` has `role="main"`.

> * 📖 [Using ARIA landmarks to identify regions of a page](https://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page)
> * 📖 [ARIA roles categorization](https://www.w3.org/TR/wai-aria/roles#roles_categorization)
### Semantics

- [ ] **Specific HTML5 input types are used:** ![Medium][medium_img] This is especially important for mobile devices that show customized keypads and widgets for different types.
Expand Down
2 changes: 1 addition & 1 deletion data/en/_items.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion data/en/_project.json

Large diffs are not rendered by default.

28 changes: 0 additions & 28 deletions data/en/items/accessibility.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,34 +41,6 @@
],
"tags": ["all", "best practices"]
},
{
"title": "Role banner",
"priority": "High",
"description": "<header> has role=\"banner\".",
"tags": ["all"]
},
{
"title": "Role navigation",
"priority": "High",
"description": "<nav> has role=\"navigation\".",
"tags": ["all"]
},
{
"title": "Role main",
"priority": "High",
"description": "<main> has role=\"main\".",
"documentation": [
{
"title": "Using ARIA landmarks to identify regions of a page",
"url": "https://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page"
},
{
"title": "ARIA roles categorization",
"url": "https://www.w3.org/TR/wai-aria/roles#roles_categorization"
}
],
"tags": ["all"]
},
{
"title": "Specific HTML5 input types are used",
"priority": "Medium",
Expand Down
40 changes: 20 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/views/base/layout.pug
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ html.no-js(lang=translation.SITE_LANGUAGE, dir=translation.SITE_DIRECTION)
.page-main

//- The main tag is not include in the block main because repeted
main.s-main#js-main(role="main")
main.s-main#js-main
block main

.page-footer
Expand Down

0 comments on commit aa722e8

Please sign in to comment.