Conflict occurs in Electron with the global property 'root'

[abruzzihraig]

In recent release version 0.2.4, the grunt file added some code like below:

 root = (typeof root !== 'undefined') ? root : {};
 factory((root.exports || (root.exports = {})), angular);

These code would be inserted to file angular-local-storage.js, and then it will cause an error in any web app which runs with Electron.

angular-local-storage/dist/angular-local-storage.js

Line 14 in 8a738f9

root = (typeof root !== 'undefined') ? root : {};

It needs to be fixed, thanks.

[ealves-pt]

Thanks mate. Do you have any suggestion? I don't have any project that run with Electron so any hint would be helpful.

[ealves-pt]

Hmmm... Fun fact is that this shouldn't have been released yet. @grevory did you create the 0.2.4 tag?

[grevory]

Yes I did. I saw the PR come in and tagged it for release. I didn't realize
at the time that you were on the ball.

Greg

On Mon, Feb 22, 2016 at 6:44 AM, Eduardo Alves notifications@github.com
wrote:

Hmmm... Fun fact is that this shouldn't have been released yet. @grevory
https://github.com/grevory did you create the 0.2.4 tag?

—
Reply to this email directly or view it on GitHub
#288 (comment)
.

[grevory]

Don't forget to update the version on new commits. I see a few others in there. Thanks!

[ealves-pt]

This should be fixed with PR #291. I will wait for some feedback to see if it's possible to close this issue.