Enable @<user>- completion popup on the release description textarea (

go-gitea#22359) For some unknown reason, this was previously disabled. Additionally removed an unused return value.
greut · Feb 1, 2023 · b6b8feb · b6b8feb
1 parent 6ba9ff7
commit b6b8feb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
@@ -328,6 +328,14 @@ func NewRelease(ctx *context.Context) {
 		}
 	}
 	ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled
+	var err error
+	// Get assignees.
+	ctx.Data["Assignees"], err = repo_model.GetRepoAssignees(ctx, ctx.Repo.Repository)
+	if err != nil {
+		ctx.ServerError("GetAssignees", err)
+		return
+	}
+
 	upload.AddUploadContext(ctx, "release")
 	ctx.HTML(http.StatusOK, tplReleaseNew)
 }
@@ -484,6 +492,13 @@ func EditRelease(ctx *context.Context) {
 	}
 	ctx.Data["attachments"] = rel.Attachments
 
+	// Get assignees.
+	ctx.Data["Assignees"], err = repo_model.GetRepoAssignees(ctx, rel.Repo)
+	if err != nil {
+		ctx.ServerError("GetAssignees", err)
+		return
+	}
+
 	ctx.HTML(http.StatusOK, tplReleaseNew)
 }
 

diff --git a/web_src/js/features/repo-release.js b/web_src/js/features/repo-release.js
@@ -17,12 +17,12 @@ export function initRepoRelease() {
 export function initRepoReleaseEditor() {
   const $editor = $('.repository.new.release .content-editor');
   if ($editor.length === 0) {
-    return false;
+    return;
   }
 
   (async () => {
     const $textarea = $editor.find('textarea');
-    await attachTribute($textarea.get(), {mentions: false, emoji: true});
+    await attachTribute($textarea.get(), {mentions: true, emoji: true});
     const easyMDE = await createCommentEasyMDE($textarea);
     initCompMarkupContentPreviewTab($editor);
     const $dropzone = $editor.parent().find('.dropzone');