DWN-37110: CCI migration openid-connect-server #15
Conversation
| fi | ||
|
|
||
| BRANCH=1.3.x | ||
|
|
There was a problem hiding this comment.
Why isn't the branch check in here like with CashProof and MarketFacingData?
There was a problem hiding this comment.
Well, on CP and MFD the branch check was to make sure you were on master before triggering release as that branch would then be inserted into the curl command. This time I inserted 1.3.x into the curl straight away, so the check is no longer necessary as no matter what branch you're on when running the script it will always trigger release build on 1.3.x
There was a problem hiding this comment.
Okay, makes sense, why didn't we do what's done here on MF and Proof?
There was a problem hiding this comment.
Sensible ideas don't all come to me at once 🤷♂️
.circleci/config.yml
Outdated
| VERSION=$(mvn -s gresham-nexus-settings/ctc.plugins.settings.xml -Dexec.executable='echo' -Dexec.args='${project.version}' --non-recursive exec:exec -q) | ||
| if [[ "${CIRCLE_BRANCH}" != "${MASTER_BRANCH}" && "${VERSION}" == *-SNAPSHOT ]]; then | ||
| # if on feature branch | ||
| REPOSITORY=altSnapshotDeploymentRepository=snapshots::default::https://nexus.greshamtech.com/repository/thirdparty-maven-snapshots/ | ||
| elif [[ "${CIRCLE_BRANCH}" == "${MASTER_BRANCH}" && "${VERSION}" == *-SNAPSHOT ]]; then | ||
| # if on 1.3.x but snapshot | ||
| REPOSITORY=altSnapshotDeploymentRepository=snapshots::default::https://nexus.greshamtech.com/repository/thirdparty-maven-snapshots/ | ||
| elif [[ "${CIRCLE_BRANCH}" == "${MASTER_BRANCH}" && "${VERSION}" != *-SNAPSHOT ]]; then | ||
| # if on 1.3.x but not snapshot (i.e building a release) | ||
| REPOSITORY=altReleaseDeploymentRepository=releases::default::https://nexus.greshamtech.com/repository/thirdparty-maven-releases/ | ||
| fi |
There was a problem hiding this comment.
Could this be simplified to be thirdparty-maven-snapshots by default and then only change when releasing?
|
@ikaoullas I think you had some 'fun' in this repo recently trying to do a patch? I don't know if you are interested in looking or whether you are aware of any gotchas that we might want to sort whilst switching to Circle? |
I don't recall updating the patch strategy for this repo. I only changed clareti-auth and clareti-common-security |
No description provided.