fix: change private field from string to boolean in react-devtools-fusebox package.json#581
Closed
fix: change private field from string to boolean in react-devtools-fusebox package.json#581
Conversation
…sebox package.json Fixes #35793 ## Problem The react-devtools-fusebox package.json has a malformed `private` field using a string value instead of a boolean: "private": "true" // ❌ Wrong (string) This violates the npm package.json specification which requires the `private` field to be a boolean: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#private ## Impact This causes failures in package scanning and validation tools: - ScanCode.io pipeline failures (pkg:github/facebook/react@v19.2.1) - Type validation errors: '"true" value must be either True or False' - Non-compliance with npm specification Related upstream issues: - aboutcode-org/scancode.io#1986 - Pipeline failure report - aboutcode-org/scancode-toolkit#4631 - Root cause analysis ## Solution Change the `private` field to a boolean value: "private": true // ✅ Correct (boolean) This 1-character fix makes the package.json compliant with the npm specification and resolves scanning failures in downstream tools.
Greptile SummaryFixes the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: ef77a63 |
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of facebook/react#35862
Original author: darshjme-codes
Fixes #35793
Problem
The package.json has a malformed
privatefield using a string value instead of a boolean:This violates the npm package.json specification which requires the
privatefield to be a boolean.Impact
This causes failures in package scanning and validation tools:
pkg:github/facebook/react@v19.2.1'"true" value must be either True or False.'Related upstream issues:
While downstream tools are adding workarounds, the source data should comply with the npm specification.
Solution
Change the
privatefield to a boolean value:{ "name": "react-devtools-fusebox", "version": "0.0.0", - "private": "true", + "private": true, "license": "MIT", }Testing
"true"and booleantruebehave identically in npm, but tools rely on correct typing)Note: Issue reporter (
@prashantsingh1819) offered to submit a PR but hasn't yet, so I'm submitting this fix to resolve the scanning failures.