Print formatted exception for station watcher #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances error reporting in the StationWatcher class within the OpenHTF framework by adding detailed traceback information to exception logs.
- Modified
openhtf/output/servers/station_server.pyto include formatted exception details in theStationWatcher.run()method - Improved error visibility by using
traceback.format_exception()for comprehensive stack traces - Enhanced debugging capabilities for issues occurring in the station watching process
- Aligned with best practices for error handling and logging in Python applications
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+185
to
+187
| formatted_exception = traceback.format_exception( | ||
| type(error), error, error.__traceback__) | ||
| _LOG.error('Error in station watcher: \n', |
There was a problem hiding this comment.
style: Consider using f-strings for better readability
Suggested change
| formatted_exception = traceback.format_exception( | |
| type(error), error, error.__traceback__) | |
| _LOG.error('Error in station watcher: \n', | |
| formatted_exception = traceback.format_exception( | |
| type(error), error, error.__traceback__) | |
| _LOG.error(f'Error in station watcher: \n{''.join(formatted_exception)}') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.