Add PHP8 Support #14
Merged
Add PHP8 Support #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyse24
approved these changes
Sep 16, 2022
groensch24
approved these changes
Sep 16, 2022
|
+1 |
|
Wow thanks! That is what I was looking for 👍 |
mfadul24
approved these changes
Sep 16, 2022
gguenther24
approved these changes
Sep 16, 2022
gpilla
approved these changes
Sep 17, 2022
|
@dsentker24 thank you! 🙂 |
|
I liked doing it. Can you tag a release please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow PHP 8 compatiblity.
Additionally, the deprecated/removed PhpUnit method
assertInternalTypewas fixed andPsr7\Utils::uriFor()is used instead of the deprecated/removedPsr7\uri_for().