Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inline display of the dialog #100

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tomasc
Copy link

@tomasc tomasc commented Oct 23, 2015

We wanted to display the recurring select dialog inline (below the select input), so we customised your plugin as follows.

The inline display can be specified using data attribute on the input:

  f.select_recurring :current_existing_rule, nil, { :allow_blank => true }, { data: { recurring_select_position: 'inline' } }

A position class (either fixed or inline) is added to the . rs_dialog_holder element and the css now supports the two options.

We also adjusted the recurring_select_dialog.js.coffee.erb so that when inline:

  • the dialog is not vertically positioned
  • clicking anywhere outside of the dialog (body) cancels it

Mainly, these changes do not break existing configurations.

@tomasc
Copy link
Author

tomasc commented Mar 26, 2016

any chance to have this merged?

no need for click when we have tap?
@emilkarl
Copy link

emilkarl commented Sep 5, 2016

This would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants