Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block UI on click #6

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Block UI on click #6

merged 5 commits into from
Nov 3, 2022

Conversation

huyndo
Copy link
Collaborator

@huyndo huyndo commented Nov 3, 2022

Adds a loading model to block UI when waiting for commands to finish. Similar to this PR in extension-example.

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fcl-next-harness ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 6:36PM (UTC)

Copy link
Owner

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. need to fix confilcts and i'll merge

@huyndo
Copy link
Collaborator Author

huyndo commented Nov 3, 2022

@gregsantos You mind checking what's wrong in Vercel bc I don't have an account there apparently

Copy link
Owner

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add loading handler for discovery api options?

@huyndo
Copy link
Collaborator Author

huyndo commented Nov 3, 2022

Should we add loading handler for discovery api options?

Added sir

@gregsantos gregsantos merged commit c166e13 into main Nov 3, 2022
@gregsantos gregsantos deleted the huyndo/block-UI-on-click branch November 8, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants