Add optional Bundler.with_unbundled_env call #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with_clean_env has been deprecated in favor of `Bundler.with_unbundled_env`
grosser
approved these changes
Jun 26, 2020
|
@grosser One CI job was failing https://travis-ci.org/github/gregorym/bump/jobs/702492747 not sure what to do about that one |
grosser
reviewed
Jun 26, 2020
spec/bump_spec.rb
Outdated
| @@ -403,7 +403,7 @@ module Foo | |||
| gemspec | |||
| RUBY | |||
| `git add Gemfile #{gemspec}` | |||
| Bundler.with_clean_env { run("bundle") } | |||
| Bundler.with_unbundled_env { run("bundle") } | |||
There was a problem hiding this comment.
use the same logic here ?
... otherwise do a gem install bundler
... can drop ruby 2.3 / 2.4 to avoid a few headaches
There was a problem hiding this comment.
Pushed new commit with same logic for specs.
Not my call about dropping older version of ruby :)
randome
force-pushed
the
fix-bundler-deprecation-warn
branch
from
f11edd8 to
a1dfc78
Compare
|
@gregorym can you bump ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with_clean_env has been deprecated in favor of
Bundler.with_unbundled_envTo avoid showing the warning message every time
bumpis ranFixes #105