Merge pull request #103 from dadah89/igor/changelog_message

Improve changelog message, mention :editor option
gregorym · Mar 14, 2020 · 5596f55 · 5596f55
2 parents 833066d + 5881698
commit 5596f55
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -116,6 +116,8 @@ require "bump/tasks"
 #
 # Maintain changelog:
 # Bump.changelog = true
+# Opens the changelog in an editor when bumping
+# Bump.changelog = :editor
 ```
 
     rake bump:current                           # display current version

diff --git a/lib/bump.rb b/lib/bump.rb
@@ -184,7 +184,7 @@ def bump_set(next_version, options)
       def bump_changelog(file, current)
         parts = File.read(file).split(/(^##+.*)/) # headlines and their content
         prev_index = parts.index { |p| p =~ /(^##+.*(\d+\.\d+\.\d+(\.[a-z]+)?).*)/ } # position of previous version
-        return "Unable to find previous version" unless prev_index
+        return "Unable to find previous version in CHANGELOG.md" unless prev_index
 
         # reuse the same style by just swapping the numbers
         new_heading = "\n" + parts[prev_index].sub($2, current)

diff --git a/spec/bump_spec.rb b/spec/bump_spec.rb
@@ -653,7 +653,7 @@ module Foo
           Wut ?
         TEXT
         f.close
-        Bump::Bump.send(:bump_changelog, f.path, '1.3.0').should == "Unable to find previous version"
+        Bump::Bump.send(:bump_changelog, f.path, '1.3.0').should == "Unable to find previous version in CHANGELOG.md"
       end
     end
   end
-Original file line number
+Diff line change
@@ Expand Up / @@ -653,7 +653,7 @@ module Foo @@
               Wut ?
             TEXT
             f.close
-            Bump::Bump.send(:bump_changelog, f.path, '1.3.0').should == "Unable to find previous version"
+            Bump::Bump.send(:bump_changelog, f.path, '1.3.0').should == "Unable to find previous version in CHANGELOG.md"
           end
         end
       end
@@ Expand Down @@