Skip to content

Commit

Permalink
Merge pull request #117 from grosser/grosser/cop3
Browse files Browse the repository at this point in the history
lock down and fix rubocop
  • Loading branch information
grosser authored May 12, 2023
2 parents c9d17d7 + 63a21ed commit 3c83630
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
6 changes: 5 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,8 @@ source "https://rubygems.org"

gemspec

gem 'byebug', platform: :mri
gem 'bundler'
gem 'debug', platform: :mri
gem 'rake'
gem 'rspec'
gem 'rubocop', '~> 1.50.0' # avoid accidental bumps since tha breaks PRs
5 changes: 0 additions & 5 deletions bump.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,4 @@ Gem::Specification.new "bump" do |s|
s.files = `git ls-files lib README.md`.split("\n")
s.license = "MIT"
s.executables = ["bump"]

s.add_development_dependency 'bundler'
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec'
s.add_development_dependency 'rubocop'
end
4 changes: 2 additions & 2 deletions lib/bump.rb
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ def bump_changelog(file, current)

def commit_message(version, options)
tag = "#{options[:tag_prefix]}#{version}"
return tag unless options[:commit_message]
return tag unless (message = options[:commit_message])

options[:commit_message].dup.gsub!('%<tag>', tag) || "#{tag} #{commit_msg}"
message.dup.gsub!('%<tag>', tag) || "#{tag} #{message}"
end

def commit(version, options)
Expand Down

0 comments on commit 3c83630

Please sign in to comment.