Skip to content

Commit

Permalink
samples: hidraw: build sample program for target architecture
Browse files Browse the repository at this point in the history
This userspace program includes UAPI headers exported to usr/include/.
'make headers' always works for the target architecture (i.e. the same
architecture as the kernel), so the sample program should be built for
the target as well. Kbuild now supports 'userprogs' for that.

I also guarded the CONFIG option by 'depends on CC_CAN_LINK' because
$(CC) may not provide libc.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
masahir0y committed May 17, 2020
1 parent 87ecdf4 commit 82d00a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion samples/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ config SAMPLE_CONNECTOR

config SAMPLE_HIDRAW
bool "hidraw sample"
depends on HEADERS_INSTALL
depends on CC_CAN_LINK && HEADERS_INSTALL

config SAMPLE_PIDFD
bool "pidfd sample"
Expand Down
9 changes: 3 additions & 6 deletions samples/hidraw/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
# List of programs to build
hostprogs := hid-example
always-y := $(hostprogs)
userprogs := hid-example
always-y := $(userprogs)

HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include

all: hid-example
userccflags += -I usr/include

0 comments on commit 82d00a9

Please sign in to comment.