Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix unclosed response bodies that are not being used #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix unclosed response bodies that are not being used #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2725d06
fix unclosed resps
domenicrosati Jun 19, 2019
3c665ea
Merge pull request #1 from domenicrosati/drosati/fix-leaks
domenicrosati Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions httpcache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,15 @@ func (t *Transport) RoundTrip(req *http.Request) (resp *http.Response, err error
for _, header := range endToEndHeaders {
cachedResp.Header[header] = resp.Header[header]
}
resp.Body.Close()
Copy link

@CAFxX CAFxX Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be ideal to do

io.Copy(io.Discard, resp.Body)
resp.Body.Close()

so that the HTTP connection can also be reused

(same below)

resp = cachedResp
} else if (err != nil || (cachedResp != nil && resp.StatusCode >= 500)) &&
req.Method == "GET" && canStaleOnError(cachedResp.Header, req.Header) {
// In case of transport failure and stale-if-error activated, returns cached content
// when available
if resp != nil && resp.Body != nil {
resp.Body.Close()
}
return cachedResp, nil
} else {
if err != nil || resp.StatusCode != http.StatusOK {
Expand Down