Skip to content

Add support for soundcloud mentions #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2018
Merged

Add support for soundcloud mentions #243

merged 2 commits into from
Nov 18, 2018

Conversation

sneljo1
Copy link
Contributor

@sneljo1 sneljo1 commented Aug 15, 2018

Soundcloud mentions/usernames include dashes.

  • Add dashes to regex for soundcloud
  • Add soundcloud as valid config option
  • Add soundcloud as mention option to comment and readme (may have missed some places, not sure)

@gregjacobs gregjacobs merged commit 0234067 into gregjacobs:master Nov 18, 2018
@gregjacobs
Copy link
Owner

@Superjo149 Thanks for this - I haven't been around to work on Autolinker in a long time and I just saw this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants