Change domain regex to not match domains with leading - or . characters #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to official specifications which are summarised here http://emailregex.com/email-validation-summary/ domain labels can't be trailing or leading by "-" character. A domain can't be also leaded by "." character as it should separate two domain labels only. I've separated IP regex as well to simplify the code and added e-mail tests to cover previously failing cases.
According to official specifications which are summarised here https://en.wikipedia.org/wiki/Email_address local part of email can't be trailing or leading by "." character. It can't contain consecutive dots also. I've also added missing special characters support and added tests.
|
Good job ! 👍 |
|
Thanks for your contribution ! Your fix is added to version 1.4.4 Feel free to submit other pull requests if you wish ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to official specifications which are summarised here http://emailregex.com/email-validation-summary/ domain labels can't be trailing or leading by "-" character. A domain can't be also leaded by "." character as it should separate two domain labels only. I've separated IP regex as well to simplify the code and added e-mail tests to cover previously failing cases.