Skip to content

Conversation

@kbs0327
Copy link
Contributor

@kbs0327 kbs0327 commented Apr 6, 2017

fixed #207

@olafleur
Copy link
Collaborator

olafleur commented Apr 6, 2017

There seems to be a failing test :

1) should NOT automatically link a hashtag that is actually a 
named anchor within a URL **when URL linking is turned off**

     Autolinker link() method hashtag linking

     Expected 'http://google.com/<a href="https://twitter.com/hashtag/link">#link</a>' 
to be 'http://google.com/#link'.

Could you take a look ?

Thanks for your contribution !

@kbs0327
Copy link
Contributor Author

kbs0327 commented Apr 6, 2017

I rollback reorder methods and solve this problem with fixing compactMatches method

@olafleur olafleur merged commit b580a86 into gregjacobs:master Apr 6, 2017
@olafleur
Copy link
Collaborator

olafleur commented Apr 6, 2017

Thank you !

@gregjacobs
Copy link
Owner

Hey guys, thanks for the contribution! I can't remember why exactly I had that while loop, but I guess if no tests break then we might be okay, lol. Might just not be possible to have multiple overlapping matches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buseung.kim@aaa.com is matched URL and Email

3 participants