Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation doesn't function if the Input facade isn't aliased #97

Closed
Gawdl3y opened this issue Dec 22, 2015 · 3 comments
Closed

Validation doesn't function if the Input facade isn't aliased #97

Gawdl3y opened this issue Dec 22, 2015 · 3 comments

Comments

@Gawdl3y
Copy link
Contributor

Gawdl3y commented Dec 22, 2015

If an application doesn't have the Input facade alias, the package's input validation will fail with an exception, due to the "Input" class not being resolvable in the IoC. Reliance upon a facade/alias is probably a bad idea for a package, since there's no guarantee they'll be present. Furthermore, Laravel 5.2's default config no longer includes the Input alias (see laravel/laravel@2adbbbd).

@0plus1
Copy link

0plus1 commented Jan 3, 2016

Thanks for the fix @Gawdl3y can you merge this change @greggilbert please?

greggilbert added a commit that referenced this issue Jan 3, 2016
@Gawdl3y
Copy link
Contributor Author

Gawdl3y commented Jan 3, 2016

Would you mind tagging a new release, @greggilbert?

@greggilbert
Copy link
Owner

@Gawdl3y So done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants