Skip to content

Conversation

krishna-bala
Copy link
Collaborator

@krishna-bala krishna-bala commented May 19, 2025

Summary

  • Prevents claude-code terminal buffer from appearing in buffer lists (:ls, :buffers)
  • Adds 'setlocal nobuflisted' when creating the terminal window
  • Includes comprehensive tests to verify the behavior

Test plan

  • Open claude-code terminal with :ClaudeCode
  • Run :ls or :buffers and confirm claude-code buffer doesn't appear
  • Verify all existing tests pass
  • Manual testing confirms terminal still functions normally

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Terminal buffers are now unlisted by default and will not appear in the buffer list.
  • Documentation
    • Updated changelog to reflect the new default behavior for terminal buffers.
  • Tests
    • Added tests to verify that terminal buffers are correctly set as unlisted.

Prevents claude-code terminal buffer from appearing in buffer lists (`:ls`, `:buffers`)
by adding 'setlocal nobuflisted' when creating the terminal window.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

coderabbitai bot commented May 19, 2025

Walkthrough

The changes update the behavior of terminal buffers so that they are unlisted by default, preventing them from appearing in the buffer list. This is implemented by setting the nobuflisted option when creating the terminal buffer. The documentation and tests are updated to reflect and verify this new behavior.

Changes

File(s) Change Summary
CHANGELOG.md Updated to document that buffers are now unlisted by default and will not appear in the :ls output.
lua/claude-code/terminal.lua Modified to set the nobuflisted buffer-local option when creating the terminal buffer.
tests/spec/terminal_spec.lua Added a test to verify that setlocal nobuflisted is issued when toggling the terminal buffer.

Poem

A buffer once listed, now hidden with care,
No longer in :ls will its name appear there.
The changelog now notes this invisible feat,
While tests ensure the behavior’s complete.
In the warren of code, all is tidy and neat!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a021225 and 0b4f98a.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • lua/claude-code/terminal.lua (1 hunks)
  • tests/spec/terminal_spec.lua (1 hunks)
🔇 Additional comments (3)
lua/claude-code/terminal.lua (1)

111-111: Proper implementation for making the buffer unlisted.

The addition of setlocal nobuflisted is the correct approach to prevent the terminal buffer from appearing in buffer lists like :ls and :buffers. This aligns perfectly with the PR objective.

tests/spec/terminal_spec.lua (1)

294-313: Well-structured test for the new feature.

This test suite correctly verifies that the nobuflisted option is set when creating the terminal buffer. The test follows the same pattern as other tests in the file, maintaining consistency in the testing approach.

CHANGELOG.md (1)

12-12: Clear and concise changelog entry.

The changelog entry properly documents the new behavior, clearly explaining that the buffer won't appear in the :ls output. This provides users with the information they need to understand the change.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@greggh
Copy link
Owner

greggh commented May 22, 2025

A newly merged request, #26, adds some conflicts here. If you watn to go review that and see if this is still needed, we can always resolve them.

@krishna-bala
Copy link
Collaborator Author

Closing this PR as it's a bit stale - I'll take another stab at it soon if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants