Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer selection dropdown #73

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Layer selection dropdown #73

merged 3 commits into from
Feb 10, 2022

Conversation

HDR
Copy link
Contributor

@HDR HDR commented Feb 8, 2022

Implements Layer Selection separately from Font Selection, use kicad's built in flip functionality for back layers.

image

image

accidentally changed test_dialog.py so this just reverts it to what it should be.
@arturo182
Copy link
Collaborator

Thank you for the addition, not a huge fan of the dropdown's position, dialog buttons usually take the whole row and form widgets go above them. But I'll leave it up to Greg since it's his repo ;)

@HDR
Copy link
Contributor Author

HDR commented Feb 9, 2022

Thank you for the addition, not a huge fan of the dropdown's position, dialog buttons usually take the whole row and form widgets go above them. But I'll leave it up to Greg since it's his repo ;)

Yeah, i was having a hard time finding a good position without shifting the entire thing.

@gregdavill
Copy link
Owner

I've moved the layer selection to what I'd consider a logic place, under the alignment.

What do you think?
Screenshot from 2022-02-10 22-36-19

@gregdavill gregdavill merged commit 3f50399 into gregdavill:main Feb 10, 2022
@gregdavill
Copy link
Owner

This all seems to work. I suppose we could add extra inner layers if they're available? Or the back layers.

But I'm okay with just having these front layers, and using the "flip" command to toggle between front/back for now.

@HDR
Copy link
Contributor Author

HDR commented Feb 10, 2022

This all seems to work. I suppose we could add extra inner layers if they're available? Or the back layers.

But I'm okay with just having these front layers, and using the "flip" command to toggle between front/back for now.

Adding the rest of the layers is as easy as just adding them to layer_choices in dialog.py, these are the other layers i left out.

F.Adhes Dwgs.User Cmts.User Eco1.User Eco2.User

@gregdavill gregdavill mentioned this pull request Feb 22, 2022
@HDR HDR deleted the layer_dropdown branch February 28, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants