feat: conditionally replace JSX attributes only when new value is defined #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves JSX attribute replacement by ensuring that attributes are only replaced when the new value is defined. Previously, attributes such as
fillwere always replaced withprops.fill, leading to unintended behavior whenprops.fillwasundefined.Motivation
While working on a React Native app, I had the following configuration in my
.svgrcfile:{ "replaceAttrValues": { "white": "{props.fill}" } }I wanted to use a transformed SVG that had two colors. However, when passing a color like
<MySvgIcon fill="red" />, both colors in the SVG were replaced with "red" instead of preserving their distinct values.When not passing a color (which is what I intended),
undefinedwas assigned tofill, causing the SVG to render incorrectly.Test Plan